Changeset 860

Show
Ignore:
Timestamp:
07/30/07 16:15:45 (1 year ago)
Author:
aronb
Message:

Remove convenience methods setValue() and getValue().

This is in responce to a message on the OpenSG-Users mailing list:

http://sourceforge.net/mailarchive/message.php?msg_name=34457a4c0706071517w41a4bad2o5804e88423c540c5%40mail.gmail.com

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • branches/fcptr_stable_jun07/Source/System/NodeCores/Drawables/Geometry/Properties/OSGGeoVectorProperty.cpp

    r564 r860  
    164164{ 
    165165} 
    166  
    167 /*-------------------- Arbitrary Type Interface Methods ------------------*/ 
    168  
    169 /*! Returns the value at index \a index in \a val after converting it to 
    170     Vec3f. 
    171     There is no range check for \a index, it must be in [0, size()[. 
    172  
    173     \note This is a convenience function and therefore not the most efficient 
    174     way to access property values. It is more efficient to obtain a pointer 
    175     or reference to the stored field an modify it directly. 
    176  
    177     \param[out] val Value at the given index. 
    178     \param[in] index Index of the element to access. 
    179  */ 
    180 void GeoVectorProperty::getValue(      Vec3f  &val, 
    181                                  const UInt32  index) const 
    182 { 
    183     MaxTypeT ival; 
    184     getValue(ival, index); 
    185     GeoConvert::convertOut(val, ival, 1, 0); 
    186 } 
    187  
    188 /*! Sets the value at index \a index to \a val. 
    189     There is no range check for \a index, it must be in [0, size()[. 
    190  
    191     \note This is a convenience function and therefore not the most efficient 
    192     way to access property values. It is more efficient to obtain a pointer 
    193     or reference to the stored field an modify it directly. 
    194  
    195     \param[in] val Value to set the element at the given index to. 
    196     \param[in] index Index of the element to set. 
    197 */ 
    198 void GeoVectorProperty::setValue(const Vec3f  &val, 
    199                                  const UInt32  index ) 
    200 { 
    201     MaxTypeT ival; 
    202     GeoConvert::convertIn(ival, val, 1, 0); 
    203     setValue(ival, index); 
    204 } 
    205  
    206166 
    207167/*! State Chunk handling */ 
  • branches/fcptr_stable_jun07/Source/System/NodeCores/Drawables/Geometry/Properties/OSGGeoVectorProperty.h

    r466 r860  
    152152    /*! \}                                                                 */ 
    153153    /*---------------------------------------------------------------------*/ 
    154     /*! \name       Some special case methods for efficiency               */ 
    155     /*! \{                                                                 */ 
    156  
    157     virtual void getValue(      Vec3f    &val, const UInt32 index ) const; 
    158     virtual void setValue(const Vec3f    &val, const UInt32 index ); 
    159  
    160     /*! \}                                                                 */ 
    161     /*---------------------------------------------------------------------*/ 
    162154    /*! \name                      Sync                                    */ 
    163155    /*! \{                                                                 */