Ticket #116 (closed enhancement: wontfix)

Opened 2 years ago

Last modified 2 months ago

FieldMask wastes least significant bit ?

Reported by: anonymous Assigned to: unassigned
Priority: major Milestone: 2.0 Beta
Component: System Version: 2.0
Keywords: Cc:
Completion:

Description

The field mask macros in OSGReflexiveContainer.h seem to waste the least significant bit of the mask, thus effectively reducing the max number of fields in a FC. I'll attach a patch with the proposed changes.

Attachments

RC_FIELD_ID.diff (1.8 kB) - added by cneumann on 10/28/06 09:11:42.
Patch to illustrate change

Change History

10/28/06 09:11:42 changed by cneumann

  • attachment RC_FIELD_ID.diff added.

Patch to illustrate change

10/28/06 09:14:28 changed by cneumann

I added a patch. It's untested and only to show what change is intended - I have not checked if other parts of the system need to be modified.

(follow-up: ↓ 3 ) 05/19/08 10:31:13 changed by cneumann

  • status changed from new to closed.
  • estimated_completion changed.
  • resolution set to wontfix.

On the other hand there is value in being able to compute the mask from the id in a very straightforward way, i.e. being able to do mask = 1 << id.

⇒ closing.

(in reply to: ↑ 2 ) 05/19/08 11:53:13 changed by dirk

Replying to cneumann:

On the other hand there is value in being able to compute the mask from the id in a very straightforward way, i.e. being able to do mask = 1 << id.

What's the problem with starting field ids at 0? In that case the LSB would be used or the first field.