Ticket #19 (closed task: fixed)

Opened 2 years ago

Last modified 1 year ago

make base function names mixed case

Reported by: cneumann Assigned to: cneumann
Priority: minor Milestone: 2.0 Beta
Component: System Version: 2.0
Keywords: Cc:
Completion:

Description

The functions in OSGBaseFunctions do not uniformly use mixed case like the rest of the system.

* rename functions * create script to fix sources * document changes in wiki Changes1To2?

Change History

(in reply to: ↑ description ) 09/04/06 12:55:14 changed by cneumann

Replying to cneumann: This should look like this:

The functions in OSGBaseFunctions do not uniformly use mixed case like the rest of the system.

  • rename functions
  • create script to fix sources
  • document changes in wiki Dev/Changes1To2

(follow-up: ↓ 3 ) 09/30/06 16:57:14 changed by dirk

Did you ever do this? If yes, could you commit the changes?

(in reply to: ↑ 2 ) 09/30/06 17:16:24 changed by cneumann

  • status changed from new to assigned.

Replying to dirk:

Did you ever do this? If yes, could you commit the changes?

Yes, I have convScript extended to handle all base functions. I'll create the patch tomorrow (2006-10-01) and commit.

10/02/06 16:01:14 changed by cneumann

Commited as r218.

The "old" function names are still available if OSG_1_COMPAT is defined. The osghton/osgntoh byte order functions are still available unconditionally and used in the source, as there are some uses in the network stuff that need to be examined carefully.

For example: 

void SocketAddress::setPort(int port)
{
    _sockaddr.sin_port = osghtons( port );
}

osghtons takes a UInt16 argument…

10/14/06 06:00:57 changed by cneumann

  • status changed from assigned to closed.
  • resolution set to fixed.

I went through the network stuff and converted everything to the new functions. This was committed as part of r286.