Ticket #46 (new defect)

Opened 2 years ago

Last modified 2 years ago

scons build: Boost option names do not match other option style

Reported by: cneumann Assigned to: allenb
Priority: minor Milestone:
Component: Build Version: 2.0
Keywords: Cc:
Completion:

Description

Just a minor nit. Attached patch fixes this, but this means scons_addons diverges from upstream, not sure that's worth it ?

The patch changes:

  • BoostBaseDir — boost
  • BoostIncludeDir — boost_incdir

Attachments

scons_addons_boost.diff (1.5 kB) - added by cneumann on 09/16/06 03:58:46.

Change History

09/16/06 03:58:46 changed by cneumann

  • attachment scons_addons_boost.diff added.

10/07/06 14:19:57 changed by dirk

  • owner changed from unassigned to allenb.

I would like to have them consistent. I don't mind changing all the others if that's necessary, but they should be consistent.

10/07/06 14:38:10 changed by allenb

  • owner changed from allenb to anonymous.
  • status changed from new to assigned.

Okay, I will probably need to change the jpeg,tiff,png,glut, and zlib options since they all use Options.PackageOption? and it is inconsistent with the other scons-addons options. I would like to hold of for a bit on this though because it is going to break all the buildbot scripts and everyone's cache files. I would like to coordinate or at least announce the change before we commit it.

10/07/06 14:39:31 changed by allenb

  • owner changed from anonymous to allenb.
  • status changed from assigned to new.